Conversation
minneee
approved these changes
Aug 12, 2025
| } | ||
| .frame(maxWidth: .infinity) | ||
| .padding(16) | ||
| .background(Color(hex: "E9EBEF")) |
Collaborator
There was a problem hiding this comment.
디자인 시스템에서 컬러 지정해서 사용하는게 아니라 hex로 컬러를 지정해서 사용하신 이유가 있으신가요??
Collaborator
Author
There was a problem hiding this comment.
동일한 컬러가 안나와있고 이름 명칭이 정의되어 있지 않아서 우선 이렇게 넣었어요
이건 맞춰가면 될 것 같습니다 !
Roy-wonji
approved these changes
Aug 12, 2025
Contributor
Roy-wonji
left a comment
Roy-wonji
left a comment
There was a problem hiding this comment.
수고 하셨습니다 코멘트 달아들린거 확인해주시면 될거 같습니다
|
|
||
| private let item: TeamExploreItem | ||
|
|
||
| private var title: String { |
Contributor
There was a problem hiding this comment.
@Peter1119 이것도 enum 안에 넣는 건 어떨까요 ? , 색상이랑 이미지도 넣어주시는거 어떨까요 ?
Collaborator
Author
There was a problem hiding this comment.
넵 저도 고민했는데 같이 묶일 데이터 인가 ? 혹은
공유될 자원인가? 이런 고민이 있어서 우선 분리 시켰는데
합쳐도 괜찮을 것같습니다 ~!
Collaborator
Author
There was a problem hiding this comment.
이미지 추가했습니다! 확인부탁드립니다 ~!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
✨ 작업 내용
📸 Showcase
📝 참고 사항
Motivation 🥳 (코드를 추가/변경하게 된 이유)
Key Changes 🔥 (주요 구현/변경 사항)
To Reviewers 🙏 (리뷰어에게 전달하고 싶은 말)
Reference 🔗
Close Issues 🔒 (닫을 Issue)
Close #No.
Checklist